search

ros-infrastructure / buildfarm_deployment

Apache License 2.0
30 stars 39 forks source link

Fix plugins loading due to outdated structs plugin #221

Closed Rayman closed 4 years ago

Rayman commented 4 years ago

I tried to install the buildfarm master on a fresh 16.04 host. Jenkins would not load due to an outdated structs plugin. After bumping the version all the other plugins started working.

I'm using the same Jenkins version as http://build.ros.org: 2.190.1

Rayman commented 4 years ago

I see this commit is already used in producation: https://github.com/ros-infrastructure/buildfarm_deployment/commit/6254e6c6e0592f071d7a001e401e00df89b78d60

jonazpiazu commented 4 years ago

:+1: to updating the version of the structs plugin.

However I would recommend to go for version 1.19 (see this comment ).

Having the older structs plugin also makes the import_upstream fail:

# BEGIN SUBSECTION: import debian packages for ubuntu_building
17:47:08 + python -u /home/jenkins-agent/workspace/import_upstream/reprepro-updater/scripts/import_upstream.py ubuntu_building /home/jenkins-agent/reprepro_config/ros_bootstrap.yaml --commit
17:47:08 python: can't open file '/home/jenkins-agent/workspace/import_upstream/reprepro-updater/scripts/import_upstream.py': [Errno 2] No such file or directory
sevenbill commented 4 years ago

I think I'm having the same issue.

Running puppet
Running puppet resulted in 6 errors and 15 warnings
Showing the last 10 error messages
2020-02-07 14:57:19 +0100 Puppet (err): java -jar /usr/share/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 -auth myci:REDACTED groovy = < /tmp/configure
_git_user.groovy returned 255 instead of one of [0]
2020-02-07 14:57:19 +0100 /Stage[main]/Profile::Jenkins::Master/Rosjenkins::Groovy[/tmp/configure_git_user.groovy]/Exec[/tmp/configure_git_user.groovy]/ret
urns (err): change from notrun to 0 failed: java -jar /usr/share/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 -auth myci:REDACTED groovy = < /tmp/confi
gure_git_user.groovy returned 255 instead of one of [0]
2020-02-07 14:58:24 +0100 Puppet (err): java -jar /usr/share/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 -auth myci:REDACTED groovy = < /tmp/complete_
setup.groovy returned 255 instead of one of [0]
2020-02-07 14:58:24 +0100 /Stage[main]/Profile::Jenkins::Master/Rosjenkins::Groovy[/tmp/complete_setup.groovy]/Exec[/tmp/complete_setup.groovy]/returns (er
r): change from notrun to 0 failed: java -jar /usr/share/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 -auth myci:REDACTED groovy = < /tmp/complete_setu
p.groovy returned 255 instead of one of [0]
2020-02-07 14:59:16 +0100 Puppet (err): java -jar /usr/share/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 -auth myci:REDACTED groovy = < /tmp/enable_tc
p_agents.groovy returned 255 instead of one of [0]
2020-02-07 14:59:16 +0100 /Stage[main]/Profile::Jenkins::Master/Rosjenkins::Groovy[/tmp/enable_tcp_agents.groovy]/Exec[/tmp/enable_tcp_agents.groovy]/retur
ns (err): change from notrun to 0 failed: java -jar /usr/share/jenkins/jenkins-cli.jar -s http://127.0.0.1:8080 -auth myci:REDACTED groovy = < /tmp/enable_
tcp_agents.groovy returned 255 instead of one of [0]

It looks like this at least partially solves this.

jonazpiazu commented 4 years ago

I have to add that in my last tests, upgrading structs plugin to 1.19 did not fix all the problems; but upgrading to 1.20 works fine (using Jenkins 2.204.1).

sevenbill commented 4 years ago

Currently have Structs plugin v1.20 working with Jenkins ver. 2.222.3 using deployment/2019-11-27 branch with some other fixes on top.

@nuclearsandwich Can this be merged into master?

nuclearsandwich commented 4 years ago

Thanks everyone for contributing here.