Shell escaping password

ros-infrastructure / buildfarm_deployment

Apache License 2.0

30 stars 39 forks source link

Shell escaping password #229

Open sevenbill opened 4 years ago

sevenbill commented 4 years ago

It looks like ui_pass should be escaped or documentation added to avoid shell unsafe characters in the password.

modules/rosjenkins/manifests/groovy.pp
10:  $jenkinsauth = "${::jenkins::slave::ui_user}:${::jenkins::slave::ui_pass}"
14:    command   => "java -jar $jarfile -s http://127.0.0.1:8080 -auth ${jenkinsauth} groovy = < $groovyfile",

tfoote commented 4 years ago

That sounds reasonable. A PR to escape it properly would be appreciated.