Support docker::registry_mirror config option.

nuclearsandwich commented 3 years ago

With Docker Hub's new rate limits1 most buildfarm configurations will hit the rate limit during normal operation. This would allow you to specify a registry mirror to pull from. One recommendded configuration would be to follow Docker's recipe for a read-through caching mirror2.

To enable this new option add a hiera config field of docker::registry_mirror to your common.yaml hiera configuration in buildfarm_deployment_config.

:construction: Note for reviewers: I haven't tested this yet. The canonical buildfarms had their changes manually deployed as a proof-of-concept. If anyone does try this out and find it working I would love to hear about it.

ros-discourse commented 3 years ago

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/read-through-caching-container-registry/17477/1

j-rivero commented 3 years ago

Changes looks good to me with the exception of minor comment about the format of the data. The configuration seems the right one to me.

ros-infrastructure / buildfarm_deployment

Support docker::registry_mirror config option. #244