Added explanation as to why targets should be prefixed with package name

[davetcoleman]

Based on discussion here: https://github.com/catkin/catkin_tools/issues/236

[dirk-thomas]

Thanks. LGTM.

[NikolausDemmel]

+1

[gavanderhoorn]

Might be nice to add that you can use set_target_properties like this:

set_target_properties(${PROJECT_NAME}_node PROPERTIES OUTPUT_NAME node PREFIX "")

to remove the prefix from your binary names again. It's not needed as the package name will provide a scope when used with other ROS infrastructure.

[davetcoleman]

@gavanderhoorn that's a good point but I was thinking I didn't want to over-complicate the CMakeLists.txt even further. But thinking about it more, that does seem like a good idea.

[gavanderhoorn]

A valid point, but if we don't add the line, we'll have new users blindly copy/pasting this and end up with things like rosrun someones_pkg someones_pkg_their_node. Not very desirable I'd say.

[davetcoleman]

I've added documentation for this new feature

[dirk-thomas]

Thank you for iterating on this. I have changed the term namespace to prefix. The modified commit has been cherry-picked in 8574d5b9fabf3ba176ea21bc3629f15912e11fc1

[davetcoleman]

thanks!