search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 91 forks source link

allow for "revision" in package version and changelog #145

Closed defunctzombie closed 8 years ago

defunctzombie commented 8 years ago

The revision is appended to the upstream version by a vendor to indicate that the package is altered from upstream packaging.

This allows for users to create packages using the proper upstream version with their own patch-set applied on top.

defunctzombie commented 8 years ago

This allows for -[0-9]+[a-z]+ to optionally follow the version. The purpose for this is to make it possible for downstream consumers to patch and release modified versions without having to alter/increment the upstream version number or the package name/release or any other tricks. This is a typical approach and naming scheme seen on debian packages when altering from the base.

Happy to also relax the check here and allow for more flexibility in what goes after the -; this was just the first pass at bringing this feature in.

defunctzombie commented 8 years ago

another possible regex is to allow -[a-z]+[0-9]+ instead

dirk-thomas commented 8 years ago

How does this affect all the other tools in e.g. the release toolchain which e.g. add a deb inc after the version, rosdistro expecting a certain version format, etc.? I would expect some of them to bail on this.

dirk-thomas commented 8 years ago

I will close this for now due to no response. Please feel free to comment on the issue and it can be reopened.