search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 91 forks source link

catkin_generate_changelog fails on hg/mercurial repositories #235

Closed kmhallen closed 5 years ago

kmhallen commented 6 years ago

Git repositories work as expected, but hg repositories fail and report tags that don't exist.

Commands to clone some hg repositories and reproduce:

cd /tmp && hg clone https://bitbucket.org/DataspeedInc/lusb
cd /tmp && hg clone https://bitbucket.org/DataspeedInc/dataspeed_can
cd /tmp && hg clone https://bitbucket.org/DataspeedInc/dbw_fca_ros
cd /tmp/lusb && catkin_generate_changelog
cd /tmp/dataspeed_can && catkin_generate_changelog
cd /tmp/dbw_fca_ros && catkin_generate_changelog

Output:

Found packages: lusb
Querying commit information since latest tag...
ERROR: The tag name '1' doesn't match the version pattern x.y.z

Found packages: dataspeed_can, dataspeed_can_msg_filters, dataspeed_can_msgs, dataspeed_can_tools, dataspeed_can_usb
Querying commit information since latest tag...
ERROR: The tag name '33' doesn't match the version pattern x.y.z

Found packages: dbw_fca, dbw_fca_can, dbw_fca_description, dbw_fca_joystick_demo, dbw_fca_msgs
Querying commit information since latest tag...
ERROR: The tag name '4' doesn't match the version pattern x.y.z
dirk-thomas commented 6 years ago

Please consider to provide a pull request to add proper support for Mercurial repositories to catkin_generate_changelog.

kmhallen commented 6 years ago

PR #236 seems to fix this issue