search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 91 forks source link

Exclude generated documentation files from flake8 test #237

Closed cottsay closed 5 years ago

cottsay commented 5 years ago

For whatever reason, the conf.py generated in the doc/_build directory on Fedora doesn't have a trailing newline, so it fails the flake8 tests. Of course this isn't a problem if you don't build docs before running the tests. There really isn't any reason to run flake8 on anything generated in the docs anyway, so we can just skip those files.

cottsay commented 5 years ago

Shoot, this works with flake8 3.4.1 on Fedora, but it appears broken in Travis. I'll find another solution.

cottsay commented 5 years ago

This solution seems to work on Ubuntu and Fedora. I have no clue why the constructor method didn't work - the docs are the same for 3.4.1 and 3.5.0.

Note that this problem is also reproducible on Ubuntu if you generate docs before running tests.

dirk-thomas commented 5 years ago

Thanks for the patch.