Closed k-okada closed 5 years ago
I don't think this should be merged. The valid tags in a manifest file are specified in an REP. Allowing other tags and mapping them magically in the catkin_pkg
implementation would break any other software trying to read the files which follow the specification strictly.
I would suggest to rather update the translated tutorials (or any other outdated documentation).
If you would like to have a more specific error message for some unknown tags (like run_depend
) that sounds fine to me.
I agree that we shouldn't magically make an invalid package.xml work. It should be fixed. But the existing warnings are much more useful and could be left there as a helpful message to tell people what to fix to allow their package.xml to be parsed before quitting.
@k-okada Are you planning to update the patch based on the feedback?
@k-okada Friendly ping.
Since there was no further response I guess just adding more detailed warnings isn't important enough. Therefore I will go ahead and close this. Please feel free to create a new PR just adding the more specific text to the error message.
@dirk-thomas sorry for late response, I look over the ping.
Coincidentally enough, I just asked "I tried to add message in my package and updated my package.xml and CMakelists.txt, after reading ros wiki, But somehow I can not run catkin build` question this morning, who just started ROS programming a few month ago. I have created new PR on #246 .
Using run_depend with package.xml is not supported, but failing with error is too much for new users, we have so many question related this issue -> see Gogle result
Note that we have not updated the translated tutorial which still assuming version 1, but actutal
catkin_create_pkg
has been updated for version http://wiki.ros.org/ja/ROS/Tutorials/CreatingMsgAndSrv