Closed k-okada closed 5 years ago
@dirk-thomas thanks for comments. I have fixed and committed newer version.
BTW, I still want to emphasize error message so that (specially) beginners do not confused with 'Traceback' and 'Error' message. How do you think raising 'InvalidPackage' exception with color formatted string.
index 9d49e61..d7f8269 100644
--- a/src/catkin_pkg/package.py
+++ b/src/catkin_pkg/package.py
@@ -41,6 +41,7 @@ import sys
import xml.dom.minidom as dom
from catkin_pkg.condition import evaluate_condition
+from catkin_pkg.terminal_color import fmt
PACKAGE_MANIFEST_FILENAME = 'package.xml'
@@ -714,7 +715,7 @@ def parse_package_string(data, filename=None, warnings=None):
errors.append('The "%s" tag must not contain the following children: %s' % (node.tagName, ', '.join([n.tagName for n in subnodes])))
if errors:
- raise InvalidPackage('Error(s):%s' % (''.join(['\n- %s' % e for e in errors])), filename)
+ raise InvalidPackage(fmt('@{rf}@{boldon}Error(s):%s' % (''.join(['\n- %s' % e for e in errors]))), filename)
Sorry , i have closed this issue by force push origin/master to k-okada/master, moved PR to #248
Added more detailed warnings when people uses
run_depend
on package.xml v2 orexec_depend
on package.xml v1.c.f. #238