search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 91 forks source link

support passing unicode to parse_package_string #253

Closed dirk-thomas closed 5 years ago

dirk-thomas commented 5 years ago

Redo of #252.

WIthout the patch the function parse_package_string works with:

With the patch it also works with unicode in Python 2.

The first commit adds the test coverage for the new use case (hence failing). The second commit implements the new support.

zultron commented 5 years ago

This looks good to me. Also replaces ros-infrastructure/rosdistro#133. The unit test here is better, too. Thanks!