Closed aurzenligl closed 5 years ago
@dirk-thomas, do you prefer review fixes visible in history as separate commits - or just as amends into original commits?
LGTM. Thanks for addressing this and iterating on the patch.
do you prefer review fixes visible in history as separate commits - or just as amends into original commits?
In general it is easier to review incremental commits since it is quicker to check what is changed in each iteration without re-reviewing the full patch. Luckily this one is fairly small - so no problem.
This bug occurs when
setup.bash
of overlaid workspace is sourced through symlink path rather than absolute path. This commit resolves symlinks inorder_path
algorithm, allowing to detect that:ws1/devel/include
starts withws1/devel_symlink
ifws1/devel_symlink
is a symlink tows1/devel
.original PR with problem description: https://github.com/ros/catkin/pull/1017
original error reproduction: https://github.com/aurzenligl/study/tree/master/ros-includedirorder