check if ros xml schema link is present

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.

https://github.com/ros/catkin

Other

47 stars 91 forks source link

Closed fabolhak closed 4 years ago

fabolhak commented 4 years ago

Adds a function to check whether a ROS schema is referenced in the package.xml.

nosetests run without problems. However, didn't check nosetests3 (don't know how to install).

fabolhak commented 4 years ago

wow, this linter is really tough

dirk-thomas commented 4 years ago

Thank you for the contribution.

I made some minor modifications - I hope they look good to you:

most important provide two functions with a slightly different name: has_ros_schema_reference and has_ros_schema_reference_string
ensure the right encoding in Python 2 before trying to parse the data (same as in another existing function)
catch exception in case the XML data is invalid (same as in another existing function)
simplified the tests to just pass strings and avoid repetition