ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 89 forks source link

Add a Suite3 option with Ubuntu Focal. #271

Closed nuclearsandwich closed 4 years ago

nuclearsandwich commented 4 years ago

This configuration option requires two recent changes in stdeb and ros_release_python:

The option allows a different set of suites to be set for Python 3 releases allowing us to forestall releasing Python2 versions of these packages for platforms where we don't plan to support Python 2.

dirk-thomas commented 4 years ago

ros-infrastructure/ros_release_python#33 has nothing to do with this change.

nuclearsandwich commented 4 years ago

ros-infrastructure/ros_release_python#33 has nothing to do with this change.

--include doesn't work at all, suite3 or no without that change. This PR won't have the intended effect without it. I updated the PR body to clarify the relationship.

dirk-thomas commented 4 years ago

--include doesn't work at all, suite3 or no without that change. This PR won't have the intended effect without it.

Yes, --include was broken. Using Suite3 or just Suite doesn't make any difference. Therefore these two changes are orthogonal.