search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 89 forks source link

catkin_install_python #275

Closed swinterbotix closed 4 years ago

swinterbotix commented 4 years ago

Hi,

According to http://wiki.ros.org/catkin/CMakeLists.txt (Section 11.1) and http://docs.ros.org/melodic/api/catkin/html/howto/format2/installing_python.html, the proper way to install Python Executable Scripts is using the 'catkin_install_python' installation function. However, I noticed that the the CMakeLists template over here (Line 156) uses the 'install' function. Shouldn't this be changed to 'catkin_install_python'?

Thanks, Solomon

dirk-thomas commented 4 years ago

Shouldn't this be changed to 'catkin_install_python'?

Yes. It would be great if you could contribute a pull request with that change.

swinterbotix commented 4 years ago

Created a Pull Request #276 to fix this issue