ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 89 forks source link

[changelog] An option to show only merge commits. #297

Closed 130s closed 3 years ago

130s commented 3 years ago

Problem this PR aims to solve

Too many items in the changelog: catkin_generat_changelog certainly helps making the complete list of changes. Problem is listing commits description of all commits isn't helpful in some/many cases unless commit history is well-made with very meaningful chunks with descriptive commit message. Even so, commit history may be more for developers, so in product development where non-developers need changelog, only top-level description of the changes (Bugfix? New capability? etc.) are needed and figuring out top-level change from the list of commit messages is difficult (particularly when the maintainer who's making the changelog is not the one that made or reviewed all the commits).

Solution taken in this PR

Open question

Example output

# catkin_generate_changelog  --only-merges                                                                                                                                                                                                         
Querying commit information since latest tag...
Updating forthcoming section of changelog files...
- updating 'b_data_collection/CHANGELOG.rst'
- updating 'b_sensor/b_asus/CHANGELOG.rst'
:
Done.

# git diff

:

diff --git a/b_support/CHANGELOG.rst b/b_support/CHANGELOG.rst
index ca6571b..6663858 100644
--- a/b_support/CHANGELOG.rst
+++ b/b_support/CHANGELOG.rst
@@ -2,6 +2,22 @@
 Changelog for package b_support
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

+Forthcoming
+-----------
+* Merge branch 'feature-enable-redundancy' into 'develop'
+  Feature enable redundancy
+  See merge request `plusone-robotics/b/b_tools!265 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/265>`_
+* Merge branch 'feature-standardize-background-init-wait' into 'develop'
+  Feature standardize background init wait
+  See merge request `plusone-robotics/b/b_tools!263 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/263>`_
+* Merge branch 'synch-master-dev-post350' into 'develop'
+  Synch master -> develop post 3.5.0
+  See merge request `plusone-robotics/b/b_tools!262 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/262>`_
+* Merge branch 'release_3.5.0' into 'master'
+  Release 3.5.0
+  See merge request `plusone-robotics/b/b_tools!261 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/261>`_
+

Without this option,

# git stash
# catkin_generate_changelog
# git diff
:
diff --git a/b_support/CHANGELOG.rst b/b_support/CHANGELOG.rst
index ca6571b..afab428 100644
--- a/b_support/CHANGELOG.rst
+++ b/b_support/CHANGELOG.rst
@@ -2,6 +2,28 @@
 Changelog for package b_support
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

+Forthcoming
+-----------
+* Merge branch 'feature-enable-redundancy' into 'develop'
+  Feature enable redundancy
+  See merge request `plusone-robotics/b/b_tools!265 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/265>`_
+* Update b_trigger_pick.yaml
+* Update b_trigger_pick.yaml
+* Update b_trigger_pick.yaml
+* Merge branch 'feature-standardize-background-init-wait' into 'develop'
+  Feature standardize background init wait
+  See merge request `plusone-robotics/b/b_tools!263 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/263>`_
+* Update ba_loa.yaml
+* Update ba_loa.yaml
+* Update ba_loa_place.yaml
+* Merge branch 'synch-master-dev-post350' into 'develop'
+  Synch master -> develop post 3.5.0
+  See merge request `plusone-robotics/b/b_tools!262 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/262>`_
+* Merge branch 'release_3.5.0' into 'master'
+  Release 3.5.0
+  See merge request `plusone-robotics/b/b_tools!261 <https://gitlab.com/plusone-robotics/b/b_tools/-/merge_requests/261>`_

CC @aaronplusone

dirk-thomas commented 3 years ago

Thanks for the patch and for iterating on it.