search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 89 forks source link

Stop using an undocumented docutils API #308

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

It looks like docutils planned to deprecate this undocumented API in their 0.18 release, but some internal changes to avoid that deprecation removed this field from the API.

From what I can tell, this code is trying to extract the text from the subtitle of each subsection to parse the date and version number for existing entries. The astext function should give us the title stripped of formatting, which is probably what we want to parse anyway.

cottsay commented 2 years ago

Ugh, I'd really like to see CI for this change - I'm not 100% confident it will work on older Python and docutils versions. We'll have to do some cross-pollination with #301 to gain confidence.

nuclearsandwich commented 2 years ago

We'll have to do some cross-pollination with #301 to gain confidence.

I'll rebase #301 onto the latest master if you want to review it, then we can merge and rebase this on to a tested master branch.