ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 89 forks source link

Resolve flake8 violations #311

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

The flake8_blind_except plugin rather aggressively identifies instances of 'except Exception' as a problem without considering that the body may re-raise the exception. Some of the cases suppressed here follow that pattern, while other perform some other reasonable action that should be taken regardless of what exception was raised.

Additionally, move D402 suppression to the docstring. It seems some (newer?) flake8 versions require this.

cottsay commented 2 years ago

Gah, much of this PR should be obsoleted by the (much better) PR already addressing flake8_blind_except: #302

cottsay commented 2 years ago

Obsoleted by #312 and #313