search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
47 stars 89 forks source link

Github links in generated changelogs to PRs are broken #319

Closed tylerjw closed 2 years ago

tylerjw commented 2 years ago

Github must have changed because all the links to PRs in changelogs generated with catkin_generate_changelog are now broken.

Example: https://raw.githubusercontent.com/ros-planning/moveit_msgs/master/CHANGELOG.rst

For an example here is the format of a generate link that is now broken:

(#135 <https://github.com/ros-planning/moveit_msgs/issues/135>_)

The correct link should be:

(#135 <https://github.com/ros-planning/moveit_msgs/pull/135>_)

This previously worked, so it must be a github change.

I found the code that I think generates these links here: https://github.com/ros-infrastructure/catkin_pkg/blob/e5f553826cff83b18cf2d438c7df6c13b3c95c4a/src/catkin_pkg/changelog_generator_vcs.py#L261

tylerjw commented 2 years ago

Closing this as the links now seem to work again. Maybe Github was broken last Friday?