Closed tylerjw closed 2 years ago
Github must have changed because all the links to PRs in changelogs generated with catkin_generate_changelog are now broken.
Example: https://raw.githubusercontent.com/ros-planning/moveit_msgs/master/CHANGELOG.rst
For an example here is the format of a generate link that is now broken:
(#135 <https://github.com/ros-planning/moveit_msgs/issues/135>_)
#135 <https://github.com/ros-planning/moveit_msgs/issues/135>
The correct link should be:
(#135 <https://github.com/ros-planning/moveit_msgs/pull/135>_)
#135 <https://github.com/ros-planning/moveit_msgs/pull/135>
This previously worked, so it must be a github change.
I found the code that I think generates these links here: https://github.com/ros-infrastructure/catkin_pkg/blob/e5f553826cff83b18cf2d438c7df6c13b3c95c4a/src/catkin_pkg/changelog_generator_vcs.py#L261
Closing this as the links now seem to work again. Maybe Github was broken last Friday?
Github must have changed because all the links to PRs in changelogs generated with catkin_generate_changelog are now broken.
Example: https://raw.githubusercontent.com/ros-planning/moveit_msgs/master/CHANGELOG.rst
For an example here is the format of a generate link that is now broken:
(
#135 <https://github.com/ros-planning/moveit_msgs/issues/135>
_)The correct link should be:
(
#135 <https://github.com/ros-planning/moveit_msgs/pull/135>
_)This previously worked, so it must be a github change.
I found the code that I think generates these links here: https://github.com/ros-infrastructure/catkin_pkg/blob/e5f553826cff83b18cf2d438c7df6c13b3c95c4a/src/catkin_pkg/changelog_generator_vcs.py#L261