search

ros-infrastructure / catkin_pkg

Standalone Python library for the catkin build system.
https://github.com/ros/catkin
Other
46 stars 89 forks source link

update catkin_prepare_release to support setup.py files #331

Closed wjwwood closed 2 years ago

wjwwood commented 2 years ago

I know some people don't like using catkin_prepare_release, but I personally enjoy it because I know what magic is happening and I like the consistency it brings in commit messages, tags, and changelog headings. But until this pull request it didn't support setup.py based packages because it would not update the version in the setup.py, only the package.xml. This pull request changes that and adds ament_python to the list of supported build types for this tool.

wjwwood commented 2 years ago

I'm not sure how worried we are about the API change.

Yeah, I'll defer to @cottsay and @nuclearsandwich on that.

wjwwood commented 2 years ago

Bump on this one, is there anything I need to do? Or are we just waiting on a window to merge and release?

nuclearsandwich commented 2 years ago

Bump on this one, is there anything I need to do? Or are we just waiting on a window to merge and release?

I had started https://github.com/ros-infrastructure/catkin_pkg/pull/332 during review but hadn't gotten around to publishing it.

nuclearsandwich commented 2 years ago

Thanks @wjwwood!

tfoote commented 2 years ago

When this is released it would be great to update the docs here: https://wiki.ros.org/action/fullsearch/bloom/Tutorials/FirstTimeRelease