ros-infrastructure / catkinize

A collection of scripts to convert ROS stacks to Catkin
3 stars 11 forks source link

Delete dry Makefile from converted packages #9

Open jack-oquin opened 11 years ago

jack-oquin commented 11 years ago

A minor point, but Makefile might as well be deleted along with the other files being removed.

ahendrix commented 11 years ago

In a few cases, the Makefile contains more the just the stock one-liner (mostly in older WG packages that fetch and build a thirdparty tarball).

It's probably worth checking the size, content or checksum of the Makefile and only removing it if it matches the default.

sotte commented 11 years ago

Am I right that these two are the only default Makefiles and therefore can be deleted safely?

For packages:

include $(shell rospack find mk)/cmake.mk

For stacks:

include $(shell rospack find mk)/cmake_stack.mk
ahendrix commented 11 years ago

Correct.