ros-infrastructure / cookbook-ros-buildfarm

Apache License 2.0
2 stars 2 forks source link

Update Jenkins plugins #108

Open nuclearsandwich opened 2 years ago

nuclearsandwich commented 2 years ago

I reviewed every plugin installed for updates to their changelogs and noted possible breaking changes where I could see them. I also added a number of TODO comments over plugins which I don't think we're directly using as well as plugins that are still listed only as possible implicit dependencies due to plugins that express dependencies on older versions of jenkins core where these plugins were part of the core.

gavanderhoorn commented 2 years ago

Did you run through the changelogs of all these plugins?

That's got to have taken some time :tired_face:

nuclearsandwich commented 2 years ago

Did you run through the changelogs of all these plugins?

Yep. Reviewed each plugin's changelog as I was going through. I missed a few plugin dependencies so I've force-pushed this commit a few times over. I was working on a tool to make compiling a PR from standalone commits easier but it's harder to manage when there are inter-dependencies between plugins that require multiple updates for an atomic commit.

As a result it's best to just update the entire system in tandem to avoid intermediate states that render Jenkins unbootable and thus can't be recovered from. Things should get a lot better with the use of the plugin-manager but I want to implement that directly in the jenkins cookbook of which I'm a maintainer-errant.

That's got to have taken some time :tired_face:

basically that was my day yesterday.

nuclearsandwich commented 2 years ago

There were a couple of plugins where I put their changes in the changelog but missed bumping the version. That's fixed in the latest push.

The junit and workflow-job plugins can't be upgraded to their latest version due to our Jenkins version as they don't currently target the LTS release and I am reserving the swarm plugin update for a dedicated PR as I will also need to test that with the agents.