ros-infrastructure / prerelease_website

1 stars 5 forks source link

rosinstall_gen only generates dry variant dependencies, not actual packages #12

Closed pallegro closed 11 years ago

pallegro commented 11 years ago

When rosinstall_gen was updated for rep 137 a bug was introduced where only the dependencies of packages in dry variants are generated, and not the actual packages themselves.

wget http://packages.ros.org/web/rosinstall/generate/raw/groovy/desktop expected result: rviz included in resulting rosinstall file actual result: rviz and 11 other packages are not included

patch for rosinstall_gen/distro.py

--- prerelease_website/rosinstall_gen/distro.py    2013-04-29 14:24:28.892862669 -0300                                                                 
+++ prerelease_website/rosinstall_gen/distro.py 2013-04-29 14:24:44.955952826 -0300                                                                         
@@ -44,6 +44,7 @@ def _generate_rosinstall(distro_name, pa                                                                                                  
         assert pkg_name in dist.packages, 'Package "%s" is not part of distro "%s"' % (pkg_name, distro_name)                                              
         all_pkgs |= walker.get_recursive_depends(pkg_name, ['buildtool', 'build', 'run'], ros_packages_only=True, ignore_pkgs=all_pkgs)                    

+    all_pkgs |= set(packages)                                                                                                                              
     rosinstalls = []                                                                                                                                       
     for pkg_name in all_pkgs:                                                                                                                              
         rosinstalls.append(_generate_rosinstall_for_package(dist, pkg_name))
dirk-thomas commented 11 years ago

Thx, fixed and deployed.