generate rosinstall files with git repo instead of tar

ros-infrastructure / prerelease_website

1 stars 5 forks source link

generate rosinstall files with git repo instead of tar #4

Closed dirk-thomas closed 11 years ago

dirk-thomas commented 11 years ago

The disadvantage when checking out tar-based versions of all these repositories is that when you need to make modifications to the sources to fix build issues there is no way to find out what was tweaked in order to provide upstream feedback.

Therefore it should be possible to generate rosinstall files which reference the git repos (with type: git) to really checkout the tag/branch.

The question is if the variant pointing to tar archives is necessary for the sake of potentially being smaller?

eitanme commented 11 years ago

This seems like a reasonable feature request. I'll throw it on the list.

tfoote commented 11 years ago

This is going to be a bit of a design challenge. The reason it's currently using the tarballs is because that is the only thing that can be computed in closed form. To get the git url you have to query the bloom branch of the gbp repo.

tfoote commented 11 years ago

To calrify, i was thinking of using the upstream url. However, it would give most of the benefit if it used the gbp git url for being able to diff etc.

dirk-thomas commented 11 years ago

This does not require any information from bloom.conf or additional lookups. The entry for i.e. catkin should just look like:

git: {local-name: catkin, uri: 'https://github.com/ros-gbp/catkin-release/', version: release/catkin/0.5.58}

instead of the current tar variant:

tar: {local-name: catkin, uri: 'https://github.com/ros-gbp/catkin-release/archive/release/catkin/0.5.58.tar.gz', version: catkin-release-release-catkin-0.5.58}

eitanme commented 11 years ago

OK, so implementing this is a bit complicated because things are, once again, different for dry, wet, fuerte, and groovy. What is the release branch structure for fuerte dry packages for bloom? Is it release/stack_name/version? Or something else?

eitanme commented 11 years ago

Also, we want to pull from the gbp right? I don't need to find the upstream url for all this stuff?

dirk-thomas commented 11 years ago

Sure, GBP only. And for dry stuff since there is no GBP it is still the tar entry (since this essentially the equivalent).

dirk-thomas commented 11 years ago

Closing the ticket here since it will not be implemented for the web rosinstall generator but for the command line equivalent linked above.