search

ros-infrastructure / prerelease_website

1 stars 5 forks source link

Prerelease web tool quietly fails when given empty entries #48

Open mxgrey opened 6 years ago

mxgrey commented 6 years ago

If you want to test a prerelease of a repo that has not already been added to the ros distro, you need to include at least existing repo to the list, or else you cannot proceed past step 2.

For people trying to test a prerelease of one or more new repos before adding them to a distro, it would be useful if the tool could work with just a list of custom repositories.

To recreate this issue, simply run the web tool and only add a custom repository. The tool will quietly freeze when you attempt to click Next at the second step.

wjwwood commented 6 years ago

I believe you can add a custom repository and remove the default first entry and then you don't need anything to be released.

mikaelarguedas commented 6 years ago

I believe you can add a custom repository and remove the default first entry and then you don't need anything to be released.

:+1: just tried it, the issue seems to be the default empty entry that prevent to go to the next step.

Though this issue is still valuable as we should probably fail in a louder way when this happens

mxgrey commented 6 years ago

It should probably freeze at the first Next and highlight that first entry with a suggestion to either fill it in or delete it before proceeding.

wjwwood commented 6 years ago

Yeah, that would be better, currently it just has a JS error on the next button of the second page. We could also just make the JS code robust to empty entries.