ros-infrastructure / prerelease_website

1 stars 5 forks source link

Add an error message for unknown ROS distributions. #50

Open clalancette opened 6 years ago

clalancette commented 6 years ago

This adds a 404 for unknown ROS distributions rather than a page that just doesn't work.

Fixes https://github.com/ros-infrastructure/prerelease_website/issues/22

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

mikaelarguedas commented 6 years ago

While we don;t ship dry distros anymore, this is specific to wet distros making it impossible to have dry_distros on the prerelease website if someone wants right ?

clalancette commented 6 years ago

While we don;t ship dry distros anymore, this is specific to wet distros making it impossible to have dry_distros on the prerelease website if someone wants right ?

I guess that is true; a dry distro would run afoul of the initial check and then just throw a 404. But as you say, we don't have any dry distros anymore, so it's not really something I could test. Should we just remove the code for dry distros?

tfoote commented 6 years ago

Should we just remove the code for dry distros? I'd say yes to removing support for dry distros. We only support rosbuild based things from source in a workspace now and we don't intend to bring it back and don't expect anyone else to use it so clearing it makes sense.

clalancette commented 6 years ago

I'd say yes to removing support for dry distros. We only support rosbuild based things from source in a workspace now and we don't intend to bring it back and don't expect anyone else to use it so clearing it makes sense.

Thanks. Done in b62288e