ros-infrastructure / prerelease_website

1 stars 5 forks source link

Dockerize prerelease website #66

Closed ramereth closed 3 months ago

ramereth commented 3 months ago

This will allow the OSL to manage this as a docker container and handle updates better in the long term. Some key changes:

Signed-off-by: Lance Albertson lance@osuosl.org

nuclearsandwich commented 3 months ago

I bootstrapped GitHub Actions on the default branch but that hasn't given me the Actions popup in this PR to allow new contributors. I've relaxed that setting for now so hopefully a subsequent push will be enough to kick that off without an additional review. If it doesn't, we might have to split the PR into adding the workflow knowing it will fail, and then fixing up the workflow.

ramereth commented 3 months ago

@nuclearsandwich for some reason I can't get the ci.yml job to run. Any ideas why that might be?

nuclearsandwich commented 3 months ago

@nuclearsandwich for some reason I can't get the ci.yml job to run. Any ideas why that might be?

Actions was added to GitHub after I left the company so I have no leftover insights. My only guess is that Actions were not enabled on the default branch when the PR was added or that the specific workflow file isn't part of the default branch.

nuclearsandwich commented 3 months ago

Closing and re-opening the PR appears to have kicked that which needed kicking.

ramereth commented 3 months ago

@nuclearsandwich oh well, if this looks good, please go ahead and merge so that I can test the deployment side of it.