ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
77 stars 95 forks source link

Set -mno-avx512f flag for all binary deb jobs #1012

Closed cottsay closed 9 months ago

cottsay commented 9 months ago

This was discussed during the ROS 2 weekly meeting today, and is necessary to avoid the automatic addition of avx512 opcodes when we happen to build packages on a supported Xeon processor.

cottsay commented 9 months ago

Now that I think about it, we may be able to do this with build_environment_variables in the config. Since the type of machine is more so an artifact of our buildfarm configuration, that would be a more appropriate place to place this constraint.

cottsay commented 9 months ago

Ooh, also, I'm not sure how this flag will behave if presented to an ARM build.

cottsay commented 9 months ago

Closing in favor of ros2/ros_buildfarm_config#288