ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
77 stars 95 forks source link

Fix `pytest-rerunfailures` installation by using apt instead of pip #1020

Closed Crola1702 closed 5 months ago

Crola1702 commented 5 months ago

See https://github.com/ros2/ci/pull/744

I used the same template as install_python3.Dockerfile.em for pytest-rerunfailures package

Crola1702 commented 5 months ago

Is there any way to test it without deploying it?

Maybe @cottsay or @nuclearsandwich know better

nuclearsandwich commented 5 months ago

Is there any way to test it without deploying it?

You can run a devel job locally when set up:

mkdir /tmp/devel-test
generate_devel_script.py https://raw.githubusercontent.com/ros2/ros_buildfarm_config/ros2/index.yaml rolling default rcl ubuntu jammy amd64 > /tmp/devel-test/run.sh

Since the ros_buildfarm scripts assume that your local branch name when generating is available in the origin remote, you either need to change origin or push the branch to the root repository rather than a fork. I did the latter in this case.

cottsay commented 4 months ago

This did regress CI after all. The job "ROS 1 Devel (3.6, colcon)" fails with:

  #22 0.326 Hit:1 http://repositories.ros.org/ubuntu/testing focal InRelease
  #22 0.916 Hit:2 http://security.ubuntu.com/ubuntu focal-security InRelease
  #22 0.956 Hit:3 http://archive.ubuntu.com/ubuntu focal InRelease
  #22 1.053 Hit:4 http://archive.ubuntu.com/ubuntu focal-updates InRelease
  #22 1.148 Hit:5 http://archive.ubuntu.com/ubuntu focal-backports InRelease
  #22 1.243 Hit:6 http://archive.ubuntu.com/ubuntu focal-security InRelease
  #22 1.300 Reading package lists...
  #22 2.146 Reading package lists...
  #22 2.960 Building dependency tree...
  #22 3.134 Reading state information...
  #22 3.149 Package python3-pytest-rerunfailures is not available, but is referred to by another package.
  #22 3.149 This may mean that the package is missing, has been obsoleted, or
  #22 3.149 is only available from another source
  #22 3.149 
  #22 3.152 E: Package 'python3-pytest-rerunfailures' has no installation candidate