search

ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Run release jobs locally against master? #609

Closed xqms closed 5 years ago

xqms commented 5 years ago

For prerelease tests, we can specify a custom repository version to test (e.g. master or some feature branch). However, the prerelease test seems to only consist of compiling the repository and running the unit tests - which is different from an actual release.

Example for a bug that went unnoticed during a prerelease test: http://build.ros.org/job/Mbin_uB64__rosmon_core__ubuntu_bionic_amd64__binary/1/display/redirect (essentially a missing package.xml dependency which was covered up by another package in the same repo)

While it is possible to run a release job locally using generate_release_script.py, it does not support overriding the repo version, meaning I have to release first, before I can run the test. Would it be a reasonable addition to add an option for the git ref to use?

This would help with packaging-related bugs, which otherwise can only be discovered by performing an actual release, then fixing the problem, and releasing again.

dirk-thomas commented 5 years ago

Would it be a reasonable addition to add an option for the git ref to use?

Sounds reasonable. Please feel free to create a pull request for this enhancement.

xqms commented 5 years ago

Thanks for the confirmation, I'll look into it.

dirk-thomas commented 5 years ago

Closing due to inactivity. Please consider to contribute a PR if you are interested in this feature.