search

ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

only pass catkin specific CMake definition for ROS 1 jobs #813

Closed dirk-thomas closed 4 years ago

dirk-thomas commented 4 years ago

This avoid the following type of CMake warning in ROS 2 jobs:

Manually-specified variables were not used by the project:

nuclearsandwich commented 4 years ago

This will eliminate warnings from variables used only for ROS 1 but CI jobs may also need something like this since some variables like INSTALL_EXAMPLES=OFF and SECURITY=ON are only used for specific projects.

dirk-thomas commented 4 years ago

CI jobs may also need something like this since some variables like INSTALL_EXAMPLES=OFF and SECURITY=ON are only used for specific projects.

Good point. I will check for those in another round.