ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
82 stars 96 forks source link

Disable automatic out-of-source CMake builds in RPMs #830

Closed cottsay closed 4 years ago

cottsay commented 4 years ago

In Fedora 33, the CMake macro was changed to automatically create and use a subdirectory for build files. We're already doing that in the Bloom templates manually, so we need to specify a macro to retain the existing behavior or the two approaches will collide and make the build step fail.

Once the new behavior is reliably part of all Fedora and EPEL systems we're targeting, we can consider modifying the Bloom templates to leverage the new feature.

Unfortunately, I don't see a very good path to transitioning to the new behavior right now, so reverting to the existing behavior seems like the best path to supporting Fedora 33 and newer.