search

ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Make the doc_independent_docker_build a little more generic. #846

Closed clalancette closed 3 years ago

clalancette commented 3 years ago

In particular:

  1. Allow the user to specify the branch to checkout on the source repository.
  2. Allow the doc_independent_docker_build to upload either via the publish-over-git publisher, or via an rsync script.

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This functionality is needed for uploading ros2_documentation to docs.ros.org. I've tested this functionality up to the upload sequence; the test buildfarm I am working on doesn't actually have the correct credentials, so I can't do an end-to-end test. I'll point out a few things of interest inline.

clalancette commented 3 years ago

All right, I think I've addressed all of the open comments. You can see the job that results from using this code along with the configuration at https://github.com/ros-staging/ros_buildfarm_config/blob/staging/ros2-documentation-build.yaml here: https://build.test.ros2.org/job/doc_ros2-documentation/

@nuclearsandwich @cottsay please take another look when you get a chance. Thanks.

clalancette commented 3 years ago

All right, going ahead and merging this. Thanks for the reviews.