ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Drop superfluous mentions of 'CentOS' #850

Closed cottsay closed 3 years ago

cottsay commented 3 years ago

We're really targeting RHEL here, so no need to discriminate which clone. The only remaining mentions in this repo stem from our use of the CentOS docker images specifically for building RHEL packages.

cottsay commented 3 years ago

may merit a major bump and/or Discourse announcement

We haven't actually released ros_buildfarm since the RPM stuff landed, so if anybody took a dependency on it, they did so on a prerelease snapshot and I'm not sure I would feel bad about breaking them :P

nuclearsandwich commented 3 years ago

We haven't actually released ros_buildfarm since the RPM stuff landed, so if anybody took a dependency on it, they did so on a prerelease snapshot and I'm not sure I would feel bad about breaking them :P

Given that we run our farm from the development branch I'm not sure I could find fault with others doing likewise but I do take the point that since this is not part of a released API or valid configuration that changing it before release doesn't warrant any special notification.