ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Un-normalize some test dependency package names #924

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

It seems that these dependencies actually use hyphens and not underscores in the package name, but it typically "just works" because pip normalizes them.

flake8-class-newline: https://github.com/AlexanderVanEck/flake8-class-newline/blob/4b70bfd4fce4d6db702ed8b4a219a93635f505d1/setup.py#L27 flake8-import-order: https://github.com/PyCQA/flake8-import-order/blob/c36c22c061e5157ff6bbb138b4b4cf06cdeedb00/flake8_import_order/__about__.py#L9

Motivation for this change is that colcon doesn't currently support the "loose" name comparison that pip employs.