ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Separate objects when passing cache and new packages to pulp sync #931

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

Previously, the package_cache was duplicated in import_and_invalidate before being modified. A recent change modified the code to use a passed object as-is. Because the same instance was also passed for packages_to_add, modifications to the cache resulted in changes to the list of packages to add.

The result was that no packages were ever removed from the target repo, effectively making the invalidation pattern inert.

Regression caused by #921