ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Switch from hacky dist_suffix to release_suffix in RPMs #939

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

This hack was used to suffix package versions with a timestamp before Bloom added support for the release_suffix macro in 0.9.2 (almost two years ago).

With this change, the build timestamps will no longer be added to packages which were released with bloom versions prior to 0.9.2.

This hack is no longer working correctly after we switched to AlmaLinux for the underlying mock configuration. The AlmaLinux config appends .alma to config['dist'], which this hack (incorrectly) assumes will contain the default value for the %dist macro in the RPM build.

Follow-up to #938 Related to ros-infrastructure/bloom#569

nuclearsandwich commented 2 years ago

With this change, the build timestamps will no longer be added to packages which were released with bloom versions prior to 0.9.2.

Hard to believe that 0.9.2 was already|only two years ago. Since both Galactic and Rolling were created with later versions of bloom, Galactic documented as using a modified 0.10.71 and Rolling in June 2020, presumably with 0.9.7 from May 2020, although the bloom version was not recorded2. This limitation doesn't concern me.

cottsay commented 2 years ago

The CI logs for this PR shows that the following package was produced by the ROS 2 Release (RPM) check: ros-rolling-rcutils-5.0.1-1.el8.20220202.230419.x86_64.rpm