search

ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Use deprecated out-of-tree build in rosdoc2. #948

Closed nuclearsandwich closed 2 years ago

nuclearsandwich commented 2 years ago

pip 21.3 switches to in-tree builds by default, deprecating out-of-tree builds. This deprecated feature is also slated for removal entirely in 22.1.

Since rosdoc2 is currently mounted read-only the current build script isn't capable of building it in place.

There is an issue on pip1 regarding this behavior where they largely conclude that this is setuptools' problem. I couldn't really find a 1:1 parallel issue in setuptools.

Longer term solutions to this problem likely involve choosing a PEP517 compliant builder such as build2 which has an out-of-tree build option or just re-locating the rosdoc2 source to a rewritable directory before installing it.

nuclearsandwich commented 2 years ago

I pushed a second commit which adds a rosdoc2 test job into the mix. I will probably also push that as an independent PR and remove it from this one before merge.

nuclearsandwich commented 2 years ago

Since all I did was truncate this branch to d1c384a I'm not waiting for CI to come back before merging.