search

ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Explicitly state no compatibility with flake8 >= 5.0.0 #970

Closed cottsay closed 2 years ago

cottsay commented 2 years ago

The latest release of flake8 drops API compatibility. We should eventually add support for the newer flake8, but this should keep CI running in the mean time.

cottsay commented 2 years ago

I'm wondering about the addition of pycodestyle; can you explain more about it?

From an offline conversation: there are dependency couplings with the newer flake8 that pip doesn't seem to want to resolve for us, so it was necessary to pin that as well even though it's not a direct dependency.