Closed cottsay closed 2 years ago
Rough outline of how this change was made:
scripts
to ros_buildfarm/scripts
sys.exit(main())
to main()
__init__.py
...commit...
run_module
template--help
on each wrapper script to ensure module names resolve.When merging, this change should not be squashed, so that the separate commits preserve the history of the script files in their new locations.
Just putting this right at the bottom because half the time I forget in the heat of battle and use the default merge. If you do the same: IMO force push the intended rebase to master.
This PR begins the process of replacing the current script-style invocation of
ros_buildfarm
code with PEP 338-style module invocation.In particular, this PR moves all of the functionality into the
ros_buildfarm
Python package and introduces wrapper scripts in place of the existing scripts. There should be no change in behavior except that the scripts can now be invoked like this:python3 -m ros_buildfarm.scripts.generate_all_jobs --help
.Much of this change was done using various forms of bash violence. All of the Python wrappers that were introduced were tested with
--help
to ensure that the module path was correct.Some of the existing scripts used
sys.exit(main())
, and these were changed to simply callmain()
as is the more predominant pattern.When merging, this change should not be squashed, so that the separate commits preserve the history of the script files in their new locations.