search

ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
81 stars 96 forks source link

Git config on Jenkins Build Server - Mdev Ubuntu Bionic #993

Closed novatel-applications-engineering closed 1 year ago

novatel-applications-engineering commented 1 year ago

Hello,

We are seeing an issue where the build is failing on the 'Mdev ubuntu Bionic" build from a Github configuration error. https://build.ros.org/view/Mdev/job/Mdev__novatel_oem7_driver__ubuntu_bionic_amd64/59/console

Is this something we can fix on our end or is it a setting on the build farm? image

Thank you for your help.

cottsay commented 1 year ago

This is not a bug in ros_buildfarm, so this isn't an appropriate place to ask for help.

I believe that the novatel_edie external project that novatel_oem7_driver is pulling in has an environmental dependency that Git be not only installed, but configured for use.

You shouldn't rely on the user to have configured git. In either novatel_edie or novatel_oem7_driver, you should set the appropriate environment variables to make Git use placeholder values for author and committer name and email: https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables#_committing. Then it won't matter what the user's environment is like.

gavanderhoorn commented 1 year ago

Is ExternalProject_Add(..) supported on the buildfarm? It's used here.

cottsay commented 1 year ago

Is ExternalProject_Add(..) supported on the buildfarm?

That macro family works fine and doesn't require that git be configured like this. There is something else in the external project that seems to require committing in some way.

gavanderhoorn commented 1 year ago

There is something else in the external project that seems to require committing in some way.

I'm not sure; IIRC, you have to explicitly disable the update step for environments which don't let you / give you a configure(d) git.

cottsay commented 1 year ago

I'm not sure; IIRC, you have to explicitly disable the update step for environments which don't let you / give you a configure(d) git.

Ah, I think you're probably right. The failed step is -gitupdate, not configure or build. So suppressing the update step should probably work.

novatel-applications-engineering commented 1 year ago

Thank you @cottsay and @gavanderhoorn, I appreciate the help. Suppressing that update fixed the issue. Sorry for posting this in the wrong place.