search

ros-infrastructure / rosdistro

Tools to work with catkinized rosdistro files
Other
7 stars 40 forks source link

fix(dependency_walker): don't get dependencies of non ROS packages #171

Open Guillaumebeuzeboc opened 1 year ago

Guillaumebeuzeboc commented 1 year ago

When using the DependencyWalker and calling get_recursive_depends with the ros_packages_only to False, the DependencyWalker tries to get the dependencies of every dependency (even the non-ROS ones). In order to get the dependencies of a package we must get the corresponding ROS package (for the XML etc). This is not possible for non ROS packages (like CMake, boost etc). Hence this causes a KeyError.

I simply added a check to verify if the package is a ROS package or not before trying to get its dependencies.

artivis commented 1 year ago

Hi @cottsay, could we get a workflow approval? Thanks.