search

ros-infrastructure / rosdoc2

Command-line tool for generating documentation for ROS 2 packages.
Apache License 2.0
29 stars 9 forks source link

Use venv to run tests in github workflow #95

Closed rkent closed 2 months ago

rkent commented 2 months ago

Here's my attempt at fixing the pip failure.

tfoote commented 2 months ago

If we're going to use a venv we should use the one natively from github actions instead of hard coding it ourselves:

I got it working here: https://github.com/ros-infrastructure/rosdoc2/pull/96/commits/e4ab62a55b5d04444e3303d6173a321b972cb3b1 in my tirals in #96

However I was really hoping to keep using the system version as that's what the users will experience unless we change the instructions to explicitly use a venv.

rkent commented 2 months ago

OK we're not going to do it this way, so I will close this.