Fix urllib import on Python3

ros-infrastructure / rosdoc_lite

A light-weight version of rosdoc that does not rely on ROS infrastructure for crawling packages.

10 stars 31 forks source link

Fix urllib import on Python3 #108

Closed yurirocha15 closed 2 months ago

yurirocha15 commented 5 months ago

This should fix #107. I added some tests to ensure that the prepare_tagfiles function is working as expected as well.

Moreover, as Melodic is now EOL, there is no need to support python2 scripts anymore. Therefore I ran 2to3 on the whole code. If you still want to support python2 in the master branch, I can try to fix only #107 while keeping the rest of the code as is.

yurirocha15 commented 3 months ago

Please do the minimal change to support the different versions. Melodic is eol , but we don't have any real versioning in this and without any significant development plans for the package, keeping changes minimal are preferable to avoid accidental regressions.

This should be able to be covered by just a conditional import.

Thank you for the review. I restored the code and added a conditional import on 69694ec. I kept the unit test commit as a way to validate that the changes are working.