enable linking to documentation hosted on third party server

ros-infrastructure / rosdoc_lite

A light-weight version of rosdoc that does not rely on ROS infrastructure for crawling packages.

10 stars 31 forks source link

enable linking to documentation hosted on third party server #73

Closed jobleier closed 5 years ago

jobleier commented 7 years ago

Rosdoc_lite supports external tag files, but unlike written in ros wiki absolute urls are not supported, because the value of 'docs_url' is always interpreted as relative path. Now there is a check whether the url is absolute (begins with http:// or https://) or not.

jack-oquin commented 7 years ago

Thanks for contributing. Your change looks OK to me.

What sort of testing do you recommend before merging it in to be picked up by the ROS build farm?

jobleier commented 5 years ago

It has been a while since I opened this PR, but now I added some unit tests for my changes. Do you think, this is a good way to test the changes?