ros-infrastructure / rosindex

The source code for generating index.ros.org
https://index.ros.org
GNU General Public License v3.0
12 stars 24 forks source link

Wrong package version displayed #301

Open 130s opened 1 year ago

130s commented 1 year ago

About moveit_setup_assistant along with moveit2 on Galatic:

tfoote commented 1 year ago

I think that the package version is being picked out of the source entry and it appears that moveit_setup_assistant has main registered as the development branch for all distros even back to galactic. It would probably be good to show that specifically separately than the rosdistro version to provide visibility to unreleased versions.

In the short term though I'd recommend considering suggesting that moveit_setup_assistant consider having development branches for the releases.

130s commented 1 year ago

It would probably be good to show that specifically separately than the rosdistro version to provide visibility to unreleased versions.

That certainly helps some usecases, maybe among advanced developers.

However, I'd imagine majority of usecases for version showing feature are for the packages installed via pre-built installer (deb for Ubuntu), where there should be only 1 version for each distro and that is the version released into each distro. So I'd say this version feature should show the released version.

tfoote commented 1 year ago

I agree, that's why I didn't close this. A pull request would be appreciated to make this happen but as it's a corner case right now for devel branches that are out of sync with the releases it's not something that we can prioritize.