search

ros-infrastructure / rosindex

The source code for generating index.ros.org
https://index.ros.org
GNU General Public License v3.0
12 stars 23 forks source link

Broken Link:https://index.ros.org/packages/rosbag2 #388

Open QuentinTorg opened 1 month ago

QuentinTorg commented 1 month ago

404 Page URL

https://index.ros.org/packages/rosbag2

Referrer URL

https://index.ros.org/p/ros_base/github-ros2-variants/#jazzy-deps

Description

clicking on the little number next to the dependency names in the left window results in a broken link. The package name itself to the right of this does have a working link

rkent commented 1 month ago

This is pretty universal, the numbers all seem to have the wrong link.

I believe this comes from:

<a href="{{site.baseurl}}/packages/{{p[0]}}"

in _includes/package_body.html.

rkent commented 1 month ago

Why is there a link attached to this number at all? I suppose it might be useful if there are multiple instances of the package. But there is no page that you can go to AFAICT that will show you a list of the package instances.

On the package page, there is a dropdown that shows the list of repository instances for a package. For example, if you go to https://index.ros.org/p/grid_map/#iron and you click on the repo name "GITHUB-ANYBOTICS-GRID_MAP" you get a dropdown showing a list of repo instances for this package. If there is anything useful to link to on the number showing how many instances, this is probably it.

I'm not sure though that there really is much interest in this. It would be easier either to give no link on the number, or simply link to that package (which is already linked in multiple places on the line).