ros-infrastructure / superflore

An extended platform release manager for Robot Operating System
Apache License 2.0
52 stars 33 forks source link

Change use of # in generated commit messages to ==... or --... on the next line #228

Closed herb-kuta-lge closed 4 years ago

herb-kuta-lge commented 5 years ago

superflore currently generates commit messages that contain lines starting with the markdown header indicator #. However, commit message lines that start with # are considered comments when amending a commit and are removed unless the user remembers to quote them. Prevent these lines from accidentally being dropped by using the alternate form of header indication: a line starting with =-s or --s underneath the header text.

allenh1 commented 5 years ago

However, commit message lines that start with # are considered comments when amending a commit and are removed unless the user remembers to quote them.

Hm... Yeah, that's definitely not so good. Thanks for catching this!

herb-kuta-lge commented 4 years ago

Resolved by #236.