Closed herb-kuta-lge closed 4 years ago
Hi @allenh1 is there anything blocking this PR? We're almost ready to publish updated meta-ros with recipes generated with superflore modified with all these open PRs and it would be nice to have it in superflore/master before we do.
Hi @allenh1 is there anything blocking this PR?
Nope, just my negligence. :)
I'll review the open ones as soon as I can.
@herb-kuta-lge one small change and this is ready.
one small change and this is ready.
Done.
Use ${ROS_UNRESOLVED_PLATFORMPKG} as the mapped value
when isn't resolved by entries in rosdep/*.yaml and add
assignments of the form
ROS_UNRESOLVED_PLATFORMPKG = "UNRESOLVED-"
to conf/ros-distro/include//generated-ros-distro.inc .
These assignments are then manually overridden in
conf/ros-distro/include//ros-distro.inc as the mappings
are determined. This make possible rapid iteration because superflore
need not be rerun until rosdep/*.yaml are updated with all of the new
mappings.
Drop using the OpenEmbedded Layer Index to guess the mapping of an unresolved platform package. It would often guess wrong, requiring a rerun of superflore. This change means that there is no longer a dependency on "bs4" and that yoctoRecipe.rosdep_cache is now only used to generate rosdep-resolved.yaml .
Also, rename generate_rosdistro_conf() to generate_ros_distro_inc() so that it corresponds to the name of the file it generates.