search

ros-interactive-manipulation / pr2_object_manipulation

PR2-specific functionality related to pickup and place tasks.
20 stars 32 forks source link

Fixed Kinect config in rviz. #54

Closed danepowell closed 10 years ago

danepowell commented 10 years ago

The color image and depth map topics, specified for the kinect in the rviz config file, don't exist. These are the topics and hints I had to use.

KaijenHsiao commented 10 years ago

The current settings work for the physical PR2, so I can't merge this pull request as-is... but if you edit pr2_interactive_manipulation_frontend/scripts/adjust_rviz_config.py to make it switch the topics and hints for the case where arg sim:=true in pr2_interactive_manipulation_desktop.launch, I'd merge that in.

danepowell commented 10 years ago

I see, I kind of figured that there was something I was missing. I'll update it accordingly on Monday.

danepowell commented 10 years ago

Should I open a new pull request, or just add a new commit to this feature branch? Thanks.

KaijenHsiao commented 10 years ago

Either way, whichever you prefer. Thanks!

danepowell commented 10 years ago

I reverted that commit, and committed a change that sets the Kinect params dynamically: https://github.com/danepowell/pr2_object_manipulation/commits/feature/rviz-fix

It seems I'm not able to re-open this pull request, maybe you can?