ros-maritime / issue_tracking

A meta repo to track the state of Maritime support in ROS 2/GazeboSim
0 stars 0 forks source link

[Guidance & Control] Thruster allocation from URDF/SDF #9

Open arjo129 opened 2 years ago

arjo129 commented 2 years ago
oKermorgant commented 2 years ago

Hi,

I'd be glad to propose a package that acts as a thruster manager from URDF.

Something similar was done in Plankton and I have adapted it to Ignition plugins.

A few remarks remain:

What do you think?

bartboogmans commented 7 months ago

What do you think?

Well I think your work fulfills many goals in this topic, and is pretty awesome. I've been reading through it and want to show my respect on this work.

It's also nicely packed: one module/node/repo to solve a single, well bounded problem. I think that benefits reusability as well. I often also see thrust allocation modules hidden within the spaghetti of other code, and I like it more like you did here.

bartboogmans commented 7 months ago

To best shape the ros-maritime framework in the future, I think we should not aim for having only a single thrust-allocation algorythm because there are many different approaches, each with their own strengths.

I think @oKermorgant sets a good example of a solution that satisfies requirements for many users, and could be the go-to solution in such cases.

Ideally I'd see convergence towards a standardized thrust-allocation-interface where solutions could be swapped out according to need.

Some ideas of features/information that could be supported/integrated in urdf

I'm just putting some ideas out there that I believe would be ideal. Any thoughts on this are welcome.

oKermorgant commented 7 months ago

Hi

As for steering thrusters I am currently funding a PhD program on this topic. If it is successfull then early developments will be on this part and will of course be open sourced.